3 button Mega Drive controller all day long.
I did go through a few third party controllers, a couple on the SNES. There was a Mega Drive shaped one actually with lots of rapid fire switches and stuff. Was still a bit shit mind.
The Konix Speedking was also very good, particularly for Sensi Soccer (*edit: thats not a Sega controller, clearly...)